This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push:
new 8c0bae0 Minor Improvement: (#700)
8c0bae0 is described below
commit 8c0bae01e57a20639f49c1d6cc4f6881e5bfd429
Author: Arturo Bernal <[email protected]>
AuthorDate: Wed Feb 10 23:18:22 2021 +0100
Minor Improvement: (#700)
* Add final variable.try to make the code read-only
---
src/main/java/org/apache/commons/lang3/ArrayUtils.java | 2 +-
src/main/java/org/apache/commons/lang3/ClassUtils.java | 4 ++--
src/main/java/org/apache/commons/lang3/RandomStringUtils.java | 2 +-
src/main/java/org/apache/commons/lang3/StringUtils.java | 6 +++---
src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java | 2 +-
.../apache/commons/lang3/concurrent/BackgroundInitializer.java | 2 +-
.../apache/commons/lang3/concurrent/EventCountCircuitBreaker.java | 2 +-
.../commons/lang3/concurrent/MultiBackgroundInitializer.java | 2 +-
src/main/java/org/apache/commons/lang3/math/Fraction.java | 2 +-
src/main/java/org/apache/commons/lang3/math/NumberUtils.java | 6 +++---
src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java | 2 +-
src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java | 2 +-
.../commons/lang3/text/translate/NumericEntityUnescaper.java | 2 +-
src/main/java/org/apache/commons/lang3/time/FastDateParser.java | 2 +-
src/main/java/org/apache/commons/lang3/time/FormatCache.java | 8 ++++----
15 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
index 6c31302..6914abf 100644
--- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
@@ -785,7 +785,7 @@ public class ArrayUtils {
* @throws IllegalArgumentException if both arguments are null
*/
public static <T> T[] add(final T[] array, final T element) {
- Class<?> type;
+ final Class<?> type;
if (array != null) {
type = array.getClass().getComponentType();
} else if (element != null) {
diff --git a/src/main/java/org/apache/commons/lang3/ClassUtils.java
b/src/main/java/org/apache/commons/lang3/ClassUtils.java
index 9f31585..d1462ed 100644
--- a/src/main/java/org/apache/commons/lang3/ClassUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ClassUtils.java
@@ -1061,7 +1061,7 @@ public class ClassUtils {
public static Class<?> getClass(
final ClassLoader classLoader, final String className, final
boolean initialize) throws ClassNotFoundException {
try {
- Class<?> clazz;
+ final Class<?> clazz;
if (namePrimitiveMap.containsKey(className)) {
clazz = namePrimitiveMap.get(className);
} else {
@@ -1173,7 +1173,7 @@ public class ClassUtils {
if (!Modifier.isPublic(candidateClass.getModifiers())) {
continue;
}
- Method candidateMethod;
+ final Method candidateMethod;
try {
candidateMethod = candidateClass.getMethod(methodName,
parameterTypes);
} catch (final NoSuchMethodException ex) {
diff --git a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
index cbf6dbc..f089394 100644
--- a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
@@ -399,7 +399,7 @@ public class RandomStringUtils {
final int gap = end - start;
while (count-- != 0) {
- int codePoint;
+ final int codePoint;
if (chars == null) {
codePoint = random.nextInt(gap) + start;
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java
b/src/main/java/org/apache/commons/lang3/StringUtils.java
index b5b233d..09450c2 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -4739,7 +4739,7 @@ public class StringUtils {
* {@code endIndex < 0} or <br>
* {@code endIndex > array.length()}
*/
- public static String join(final Object[] array, String delimiter, final
int startIndex, final int endIndex) {
+ public static String join(final Object[] array, final String delimiter,
final int startIndex, final int endIndex) {
if (array == null) {
return null;
}
@@ -5423,8 +5423,8 @@ public class StringUtils {
}
private static int[] matches(final CharSequence first, final CharSequence
second) {
- CharSequence max;
- CharSequence min;
+ final CharSequence max;
+ final CharSequence min;
if (first.length() > second.length()) {
max = first;
min = second;
diff --git a/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
b/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
index f7d5fc8..103f2e5 100644
--- a/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
+++ b/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java
@@ -811,7 +811,7 @@ public class DiffBuilder<T> implements
Builder<DiffResult<T>> {
return this;
}
- Object objectToTest;
+ final Object objectToTest;
if (lhs != null) {
objectToTest = lhs;
} else {
diff --git
a/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
b/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
index d424c21..963dee3 100644
---
a/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
+++
b/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
@@ -175,7 +175,7 @@ public abstract class BackgroundInitializer<T> implements
// Determine the executor to use and whether a temporary one has to
// be created
- ExecutorService tempExec;
+ final ExecutorService tempExec;
executor = getExternalExecutor();
if (executor == null) {
executor = tempExec = createExecutor();
diff --git
a/src/main/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.java
b/src/main/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.java
index 2d44a12..051f924 100644
---
a/src/main/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.java
+++
b/src/main/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.java
@@ -376,7 +376,7 @@ public class EventCountCircuitBreaker extends
AbstractCircuitBreaker<Integer> {
*/
private CheckIntervalData nextCheckIntervalData(final int increment,
final CheckIntervalData currentData, final State currentState,
final long time) {
- CheckIntervalData nextData;
+ final CheckIntervalData nextData;
if (stateStrategy(currentState).isCheckIntervalFinished(this,
currentData, time)) {
nextData = new CheckIntervalData(increment, time);
} else {
diff --git
a/src/main/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializer.java
b/src/main/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializer.java
index 7b37e4e..08c9b34 100644
---
a/src/main/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializer.java
+++
b/src/main/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializer.java
@@ -176,7 +176,7 @@ public class MultiBackgroundInitializer
*/
@Override
protected MultiBackgroundInitializerResults initialize() throws Exception {
- Map<String, BackgroundInitializer<?>> inits;
+ final Map<String, BackgroundInitializer<?>> inits;
synchronized (this) {
// create a snapshot to operate on
inits = new HashMap<>(
diff --git a/src/main/java/org/apache/commons/lang3/math/Fraction.java
b/src/main/java/org/apache/commons/lang3/math/Fraction.java
index 4e560ca..ba077df 100644
--- a/src/main/java/org/apache/commons/lang3/math/Fraction.java
+++ b/src/main/java/org/apache/commons/lang3/math/Fraction.java
@@ -178,7 +178,7 @@ public final class Fraction extends Number implements
Comparable<Fraction> {
if (numerator < 0) {
throw new ArithmeticException("The numerator must not be
negative");
}
- long numeratorValue;
+ final long numeratorValue;
if (whole < 0) {
numeratorValue = whole * (long) denominator - numerator;
} else {
diff --git a/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
b/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
index c984dbf..ade72b0 100644
--- a/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
+++ b/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
@@ -683,9 +683,9 @@ public class NumberUtils {
return createInteger(str);
}
final char lastChar = str.charAt(length - 1);
- String mant;
- String dec;
- String exp;
+ final String mant;
+ final String dec;
+ final String exp;
final int decPos = str.indexOf('.');
final int expPos = str.indexOf('e') + str.indexOf('E') + 1; // assumes
both not present
// if both e and E are present, this is caught by the checks on expPos
(which prevent IOOBE)
diff --git a/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
b/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
index 7b1a476..19440c4 100644
--- a/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
+++ b/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
@@ -1021,7 +1021,7 @@ public class MethodUtils {
int interfaceIndex = 0;
while (interfaceIndex < allInterfaces.size() ||
superClassIndex < allSuperclasses.size()) {
- Class<?> acls;
+ final Class<?> acls;
if (interfaceIndex >= allInterfaces.size()) {
acls = allSuperclasses.get(superClassIndex++);
} else if ((superClassIndex >= allSuperclasses.size()) ||
(interfaceIndex < superClassIndex) || !(superClassIndex < interfaceIndex)) {
diff --git a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
index 5580274..4f00a4c 100644
--- a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
+++ b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
@@ -885,7 +885,7 @@ public class TypeUtils {
}
final Type ownerType = parameterizedType.getOwnerType();
- Map<TypeVariable<?>, Type> typeVarAssigns;
+ final Map<TypeVariable<?>, Type> typeVarAssigns;
if (ownerType instanceof ParameterizedType) {
// get the owner type arguments first
diff --git
a/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
b/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
index c18f58d..024a541 100644
---
a/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
+++
b/src/main/java/org/apache/commons/lang3/text/translate/NumericEntityUnescaper.java
@@ -133,7 +133,7 @@ public class NumericEntityUnescaper extends
CharSequenceTranslator {
}
}
- int entityValue;
+ final int entityValue;
try {
if (isHex) {
entityValue = Integer.parseInt(input.subSequence(start,
end).toString(), 16);
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
index b8db4d7..d34a42c 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
@@ -131,7 +131,7 @@ public class FastDateParser implements DateParser,
Serializable {
final Calendar definingCalendar = Calendar.getInstance(timeZone,
this.locale);
- int centuryStartYear;
+ final int centuryStartYear;
if (centuryStart!=null) {
definingCalendar.setTime(centuryStart);
centuryStartYear = definingCalendar.get(Calendar.YEAR);
diff --git a/src/main/java/org/apache/commons/lang3/time/FormatCache.java
b/src/main/java/org/apache/commons/lang3/time/FormatCache.java
index f2f3d8a..4a568cd 100644
--- a/src/main/java/org/apache/commons/lang3/time/FormatCache.java
+++ b/src/main/java/org/apache/commons/lang3/time/FormatCache.java
@@ -189,7 +189,7 @@ abstract class FormatCache<F extends Format> {
String pattern = cDateTimeInstanceCache.get(key);
if (pattern == null) {
try {
- DateFormat formatter;
+ final DateFormat formatter;
if (dateStyle == null) {
formatter =
DateFormat.getTimeInstance(timeStyle.intValue(), safeLocale);
} else if (timeStyle == null) {
@@ -217,7 +217,7 @@ abstract class FormatCache<F extends Format> {
*/
private static final class ArrayKey {
- private static int computeHashCode(Object[] keys) {
+ private static int computeHashCode(final Object[] keys) {
final int prime = 31;
int result = 1;
result = prime * result + Arrays.hashCode(keys);
@@ -243,7 +243,7 @@ abstract class FormatCache<F extends Format> {
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (this == obj) {
return true;
}
@@ -253,7 +253,7 @@ abstract class FormatCache<F extends Format> {
if (getClass() != obj.getClass()) {
return false;
}
- ArrayKey other = (ArrayKey) obj;
+ final ArrayKey other = (ArrayKey) obj;
return Arrays.deepEquals(keys, other.keys);
}
