[commons-vfs] branch master updated: Stub out a log call as a TODO (handle PMD issues)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new bd6ccba  Stub out a log call as a TODO (handle PMD issues)
bd6ccba is described below

commit bd6ccbaa85a15f134e0c4d29a6ee315d0bed997f
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Mar 3 10:03:35 2021 -0500

    Stub out a log call as a TODO (handle PMD issues)
---
 .../commons/vfs2/provider/webdav4/Webdav4FileObject.java   | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git 
a/commons-vfs2-jackrabbit2/src/main/java/org/apache/commons/vfs2/provider/webdav4/Webdav4FileObject.java
 
b/commons-vfs2-jackrabbit2/src/main/java/org/apache/commons/vfs2/provider/webdav4/Webdav4FileObject.java
index b99284a..366790a 100644
--- 
a/commons-vfs2-jackrabbit2/src/main/java/org/apache/commons/vfs2/provider/webdav4/Webdav4FileObject.java
+++ 
b/commons-vfs2-jackrabbit2/src/main/java/org/apache/commons/vfs2/provider/webdav4/Webdav4FileObject.java
@@ -145,7 +145,7 @@ public class Webdav4FileObject extends 
Http4FileObject<Webdav4FileSystem> {
                         executeRequest(request);
                         isCheckedIn = false;
                     } catch (final FileSystemException ex) {
-                        // Ignore the exception checking out.
+                        log(ex);
                     }
                 }
 
@@ -163,7 +163,8 @@ public class Webdav4FileObject extends 
Http4FileObject<Webdav4FileSystem> {
                             executeRequest(request);
                             isCheckedIn = true;
                         } catch (final Exception e) {
-                            // Ignore the exception. Going to throw original.
+                            // Going to throw original.
+                            log(ex);
                         }
                         throw ex;
                     }
@@ -174,7 +175,7 @@ public class Webdav4FileObject extends 
Http4FileObject<Webdav4FileSystem> {
                         final DavPropertySet props = 
getPropertyNames(fileName);
                         isCheckedIn = 
!props.contains(VersionControlledResource.CHECKED_OUT);
                     } catch (final FileNotFoundException fnfe) {
-                        // Ignore the error
+                        log(fnfe);
                     }
                 }
                 if (!isCheckedIn) {
@@ -190,7 +191,8 @@ public class Webdav4FileObject extends 
Http4FileObject<Webdav4FileSystem> {
                 try {
                     setUserName(fileName, urlStr);
                 } catch (final IOException e) {
-                    // Ignore the exception if unable to set the user name.
+                    // Unable to set the user name.
+                    log(e);
                 }
             }
             ((DefaultFileContent) this.file.getContent()).resetAttributes();
@@ -226,6 +228,10 @@ public class Webdav4FileObject extends 
Http4FileObject<Webdav4FileSystem> {
         this(name, fileSystem, Webdav4FileSystemConfigBuilder.getInstance());
     }
 
+    void log(Exception ex) {
+        // TODO Consider logging
+    }
+
     protected Webdav4FileObject(final AbstractFileName name, final 
Webdav4FileSystem fileSystem,
             final Webdav4FileSystemConfigBuilder builder) throws 
FileSystemException {
         super(name, fileSystem, builder);