This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit c34749edddf0188871f1031ad72fe680b228dbe7 Author: Alex Herbert <[email protected]> AuthorDate: Sun Apr 25 21:01:14 2021 +0100 RNG-132: Create o.a.c.rng.sampling.shape package Move UnitBallSampler to the shape package. --- .../main/java/org/apache/commons/rng/sampling/package-info.java | 6 ++++++ .../apache/commons/rng/sampling/{ => shape}/UnitBallSampler.java | 3 ++- .../org/apache/commons/rng/sampling/{ => shape}/package-info.java | 8 +++----- .../commons/rng/sampling/{ => shape}/UnitBallSamplerTest.java | 4 +++- src/changes/changes.xml | 3 +++ 5 files changed, 17 insertions(+), 7 deletions(-) diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java index 2d3445f..e578a9e 100644 --- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java +++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java @@ -21,8 +21,14 @@ * <p> * This package provides sampling utilities. * </p> + * <p> * The {@link org.apache.commons.rng.sampling.distribution distribution} * sub-package provides sampling from statistical distributions. + * </p> + * <p> + * The {@link org.apache.commons.rng.sampling.shape shape} + * sub-package provides sampling coordinates from shapes. + * </p> */ package org.apache.commons.rng.sampling; diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/UnitBallSampler.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/shape/UnitBallSampler.java similarity index 98% rename from commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/UnitBallSampler.java rename to commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/shape/UnitBallSampler.java index 4c359b5..f6356bb 100644 --- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/UnitBallSampler.java +++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/shape/UnitBallSampler.java @@ -15,9 +15,10 @@ * limitations under the License. */ -package org.apache.commons.rng.sampling; +package org.apache.commons.rng.sampling.shape; import org.apache.commons.rng.UniformRandomProvider; +import org.apache.commons.rng.sampling.SharedStateSampler; import org.apache.commons.rng.sampling.distribution.NormalizedGaussianSampler; import org.apache.commons.rng.sampling.distribution.ZigguratNormalizedGaussianSampler; diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/shape/package-info.java similarity index 77% copy from commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java copy to commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/shape/package-info.java index 2d3445f..837c86f 100644 --- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/package-info.java +++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/shape/package-info.java @@ -16,13 +16,11 @@ */ /** - * <h3>Samplers</h3> + * <h3>Shape samplers</h3> * * <p> - * This package provides sampling utilities. + * This package contains classes for sampling coordinates from shapes, for example a unit ball. * </p> - * The {@link org.apache.commons.rng.sampling.distribution distribution} - * sub-package provides sampling from statistical distributions. */ -package org.apache.commons.rng.sampling; +package org.apache.commons.rng.sampling.shape; diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/UnitBallSamplerTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/shape/UnitBallSamplerTest.java similarity index 98% rename from commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/UnitBallSamplerTest.java rename to commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/shape/UnitBallSamplerTest.java index 6f2b9b0..67c6bba 100644 --- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/UnitBallSamplerTest.java +++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/shape/UnitBallSamplerTest.java @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.commons.rng.sampling; +package org.apache.commons.rng.sampling.shape; import org.junit.Assert; import org.junit.Test; @@ -23,6 +23,8 @@ import java.util.Arrays; import org.apache.commons.math3.stat.inference.ChiSquareTest; import org.apache.commons.rng.UniformRandomProvider; import org.apache.commons.rng.core.source64.SplitMix64; +import org.apache.commons.rng.sampling.RandomAssert; +import org.apache.commons.rng.sampling.RandomAssert.Sampler; /** * Test for {@link UnitBallSampler}. diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 2d24b13..1ab4aa9 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -75,6 +75,9 @@ re-run tests that fail, and pass the build if they succeed within the allotted number of reruns (the test will be marked as 'flaky' in the report). "> + <action dev="aherbert" type="add" issue="132"> + New "o.a.c.rng.sampling.shape" package for sampling coordinates from shapes. + </action> <action dev="aherbert" type="fix" issue="130"> "UnitSphereSampler": Fix 1 dimension sampling to only return vectors containing 1 or -1. </action>
