This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git
The following commit(s) were added to refs/heads/master by this push:
new bd39a1c Use empty array. (#61)
bd39a1c is described below
commit bd39a1c9cfb3ee394791f7e015a3045d042c01ba
Author: Arturo Bernal <[email protected]>
AuthorDate: Wed Oct 6 14:15:16 2021 +0200
Use empty array. (#61)
---
src/main/java/org/apache/commons/cli/GnuParser.java | 2 +-
src/main/java/org/apache/commons/cli/PosixParser.java | 2 +-
src/main/java/org/apache/commons/cli/Util.java | 6 ++++++
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/cli/GnuParser.java
b/src/main/java/org/apache/commons/cli/GnuParser.java
index 7088c55..4126352 100644
--- a/src/main/java/org/apache/commons/cli/GnuParser.java
+++ b/src/main/java/org/apache/commons/cli/GnuParser.java
@@ -85,6 +85,6 @@ public class GnuParser extends Parser {
}
}
- return tokens.toArray(new String[tokens.size()]);
+ return tokens.toArray(Util.EMPTY_STRING_ARRAY);
}
}
diff --git a/src/main/java/org/apache/commons/cli/PosixParser.java
b/src/main/java/org/apache/commons/cli/PosixParser.java
index 7d7838f..b304668 100644
--- a/src/main/java/org/apache/commons/cli/PosixParser.java
+++ b/src/main/java/org/apache/commons/cli/PosixParser.java
@@ -176,7 +176,7 @@ public class PosixParser extends Parser {
gobble(iter);
}
- return tokens.toArray(new String[tokens.size()]);
+ return tokens.toArray(Util.EMPTY_STRING_ARRAY);
}
/**
diff --git a/src/main/java/org/apache/commons/cli/Util.java
b/src/main/java/org/apache/commons/cli/Util.java
index 7e44fbb..de52265 100644
--- a/src/main/java/org/apache/commons/cli/Util.java
+++ b/src/main/java/org/apache/commons/cli/Util.java
@@ -21,6 +21,12 @@ package org.apache.commons.cli;
* Contains useful helper methods for classes within this package.
*/
final class Util {
+
+ /**
+ * An empty immutable {@code String} array.
+ */
+ static final String[] EMPTY_STRING_ARRAY = new String[0];
+
/**
* Remove the leading and trailing quotes from {@code str}. E.g. if str is
'"one two"', then 'one two' is returned.
*