This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git


The following commit(s) were added to refs/heads/master by this push:
     new 1a70cb0  Consistent constant names and values
1a70cb0 is described below

commit 1a70cb0b48d1c69a427f2f0ab91e9e503d5c68e8
Author: Alex Herbert <[email protected]>
AuthorDate: Sat Oct 23 12:47:09 2021 +0100

    Consistent constant names and values
---
 .../apache/commons/statistics/distribution/NormalDistribution.java    | 4 ++--
 .../apache/commons/statistics/distribution/PoissonDistribution.java   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/NormalDistribution.java
 
b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/NormalDistribution.java
index 603dd24..fd8610e 100644
--- 
a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/NormalDistribution.java
+++ 
b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/NormalDistribution.java
@@ -29,7 +29,7 @@ import 
org.apache.commons.rng.sampling.distribution.ZigguratSampler;
  */
 public final class NormalDistribution extends AbstractContinuousDistribution {
     /** 0.5 * ln(2 * pi). Computed to 25-digits precision. */
-    private static final double HALF_LOG_2_PI = 0.9189385332046727417803297;
+    private static final double HALF_LOG_TWO_PI = 0.9189385332046727417803297;
 
     /** Mean of this distribution. */
     private final double mean;
@@ -58,7 +58,7 @@ public final class NormalDistribution extends 
AbstractContinuousDistribution {
                                double sd) {
         this.mean = mean;
         standardDeviation = sd;
-        logStandardDeviationPlusHalfLog2Pi = Math.log(sd) + HALF_LOG_2_PI;
+        logStandardDeviationPlusHalfLog2Pi = Math.log(sd) + HALF_LOG_TWO_PI;
         // Minimise rounding error by computing sqrt(2 * sd * sd) exactly.
         // Compute using extended precision with care to avoid over/underflow.
         sdSqrt2 = ExtendedPrecision.sqrt2xx(sd);
diff --git 
a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
 
b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
index 4d6ecb5..aeae44c 100644
--- 
a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
+++ 
b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
@@ -24,8 +24,8 @@ import 
org.apache.commons.rng.sampling.distribution.PoissonSampler;
  * Implementation of the <a 
href="http://en.wikipedia.org/wiki/Poisson_distribution";>Poisson 
distribution</a>.
  */
 public final class PoissonDistribution extends AbstractDiscreteDistribution {
-    /** 0.5 * ln(2 &pi;). */
-    private static final double HALF_LOG_TWO_PI = 0.5 * Math.log(2 * Math.PI);
+    /** 0.5 * ln(2 * pi). Computed to 25-digits precision. */
+    private static final double HALF_LOG_TWO_PI = 0.9189385332046727417803297;
     /** Default maximum number of iterations. */
     private static final int DEFAULT_MAX_ITERATIONS = 10000000;
     /** Default convergence criterion. */

Reply via email to