[commons-pool] branch master updated: Simplify assertion with similar call but simpler. (#131)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/master by this push:
     new 47f1fdd  Simplify assertion with similar call but simpler. (#131)
47f1fdd is described below

commit 47f1fdde99a24dbb7cb59c7d860a4d1e1572ebdd
Author: Arturo Bernal <arturobern...@gmail.com>
AuthorDate: Thu Mar 3 01:48:54 2022 +0100

    Simplify assertion with similar call but simpler. (#131)
---
 .../org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java   | 2 +-
 .../java/org/apache/commons/pool2/impl/TestGenericObjectPool.java   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java 
b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
index 1972989..976acab 100644
--- 
a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
+++ 
b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
@@ -2591,7 +2591,7 @@ public class TestGenericKeyedObjectPool extends 
TestKeyedObjectPool {
       gkoPool.clear("six");
       Thread.sleep(20);
       for (Thread t : testThreads) {
-          assertTrue(!t.isAlive());
+          assertFalse(t.isAlive());
       }
   }
 
diff --git 
a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java 
b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
index aa66595..9f10494 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
@@ -672,8 +672,8 @@ public class TestGenericObjectPool extends 
TestBaseObjectPool {
         // Order, oldest to youngest, is "0", "1", ...,"4"
         genericObjectPool.evict(); // Should evict "0" and "1"
         final Object obj = genericObjectPool.borrowObject();
-        assertFalse(obj.equals("0"), "oldest not evicted");
-        assertFalse(obj.equals("1"), "second oldest not evicted");
+        assertNotEquals("0", obj, "oldest not evicted");
+        assertNotEquals("1", obj, "second oldest not evicted");
         // 2 should be next out for FIFO, 4 for LIFO
         assertEquals(lifo ? "4" : "2" , obj,"Wrong instance returned");
     }
@@ -2620,7 +2620,7 @@ public class TestGenericObjectPool extends 
TestBaseObjectPool {
         {
             // The object receives an Exception during its creation to prevent
             // memory leaks. See BaseGenericObjectPool constructor for more 
details.
-            assertEquals(false, 
"".equals(genericObjectPool.getCreationStackTrace()));
+            assertNotEquals("", genericObjectPool.getCreationStackTrace());
         }
         {
             assertEquals(0, genericObjectPool.getBorrowedCount());