[commons-compress] branch master updated: Fix broken tests.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 967c59bc Fix broken tests.
967c59bc is described below

commit 967c59bce0e60fdffe7d85d33150c85d4eef0e94
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu May 5 15:32:52 2022 -0400

    Fix broken tests.
---
 .../commons/compress/compressors/deflate/DeflateParameters.java   | 5 ++++-
 .../compress/compressors/deflate/DeflateParametersTest.java       | 8 ++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/compress/compressors/deflate/DeflateParameters.java
 
b/src/main/java/org/apache/commons/compress/compressors/deflate/DeflateParameters.java
index 7679942a..7e084add 100644
--- 
a/src/main/java/org/apache/commons/compress/compressors/deflate/DeflateParameters.java
+++ 
b/src/main/java/org/apache/commons/compress/compressors/deflate/DeflateParameters.java
@@ -27,6 +27,9 @@ import java.util.zip.Deflater;
  */
 public class DeflateParameters {
 
+    static final int MAX_LEVEL = 9;
+    static final int MIN_LEVEL = 0;
+
     private boolean zlibHeader = true;
     private int compressionLevel = Deflater.DEFAULT_COMPRESSION;
 
@@ -70,7 +73,7 @@ public class DeflateParameters {
      * @see Deflater#BEST_COMPRESSION
      */
     public void setCompressionLevel(final int compressionLevel) {
-        if (compressionLevel < -1 || compressionLevel > 9) {
+        if (compressionLevel < MIN_LEVEL || compressionLevel > MAX_LEVEL) {
             throw new IllegalArgumentException("Invalid Deflate compression 
level: " + compressionLevel);
         }
         this.compressionLevel = compressionLevel;
diff --git 
a/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateParametersTest.java
 
b/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateParametersTest.java
index 0890c557..7d80efb4 100644
--- 
a/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateParametersTest.java
+++ 
b/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateParametersTest.java
@@ -18,6 +18,10 @@
  */
 package org.apache.commons.compress.compressors.deflate;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import java.io.IOException;
+
 import org.junit.Assert;
 import org.junit.jupiter.api.Test;
 
@@ -33,12 +37,12 @@ public class DeflateParametersTest {
     @Test
     public void shouldNotBeAbleToSetCompressionLevelToANegativeValue() {
         final DeflateParameters p = new DeflateParameters();
-        p.setCompressionLevel(-2);
+        assertThrows(IllegalArgumentException.class, () -> 
p.setCompressionLevel(DeflateParameters.MIN_LEVEL - 1));
     }
 
     @Test
     public void shouldNotBeAbleToSetCompressionLevelToADoubleDigitValue() {
         final DeflateParameters p = new DeflateParameters();
-        p.setCompressionLevel(12);
+        assertThrows(IllegalArgumentException.class, () -> 
p.setCompressionLevel(DeflateParameters.MAX_LEVEL + 1));
     }
 }