[commons-codec] branch master updated: Use a string joiner.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 8871e9c7 Use a string joiner.
8871e9c7 is described below

commit 8871e9c72eefda5b047d8e9fcc3654e5fab3c198
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 9 08:03:33 2022 -0400

    Use a string joiner.
---
 .../apache/commons/codec/language/bm/PhoneticEngine.java  | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java 
b/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
index 65d26757..69abac28 100644
--- a/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
+++ b/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
@@ -22,7 +22,6 @@ import java.util.Arrays;
 import java.util.Collections;
 import java.util.EnumMap;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Locale;
@@ -30,6 +29,7 @@ import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
 import java.util.TreeMap;
+import java.util.stream.Collectors;
 
 import org.apache.commons.codec.language.bm.Languages.LanguageSet;
 import org.apache.commons.codec.language.bm.Rule.Phoneme;
@@ -252,17 +252,8 @@ public class PhoneticEngine {
      * @param sep       String to separate them with
      * @return a single String consisting of each element of {@code strings} 
interleaved by {@code sep}
      */
-    private static String join(final Iterable<String> strings, final String 
sep) {
-        final StringBuilder sb = new StringBuilder();
-        final Iterator<String> si = strings.iterator();
-        if (si.hasNext()) {
-            sb.append(si.next());
-        }
-        while (si.hasNext()) {
-            sb.append(sep).append(si.next());
-        }
-
-        return sb.toString();
+    private static String join(final List<String> strings, final String sep) {
+        return strings.stream().collect(Collectors.joining(sep));
     }
 
     private static final int DEFAULT_MAX_PHONEMES = 20;