This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
commit c3548fec20fa9a6053d4ee9dd7fb0890333f84f0 Author: Gary Gregory <[email protected]> AuthorDate: Mon Nov 28 14:04:07 2022 -0500 Use try-with-resources --- .../org/apache/commons/jexl3/ClassCreator.java | 52 +++++++++++----------- .../java/org/apache/commons/jexl3/ScriptTest.java | 12 ++--- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/src/test/java/org/apache/commons/jexl3/ClassCreator.java b/src/test/java/org/apache/commons/jexl3/ClassCreator.java index 987d8aa5..e3685ec3 100644 --- a/src/test/java/org/apache/commons/jexl3/ClassCreator.java +++ b/src/test/java/org/apache/commons/jexl3/ClassCreator.java @@ -137,33 +137,33 @@ public class ClassCreator { } void generate(final boolean ftor) throws Exception { - final FileWriter aWriter = new FileWriter(new File(packageDir, sourceName), false); - aWriter.write("package "); - aWriter.write(GEN_PACKAGE); - aWriter.write(";\n"); - if (ftor) { - aWriter.write("import "+ JEXL_PACKAGE +".JexlContext;"); - aWriter.write(";\n"); - } - aWriter.write("public class " + className); - aWriter.write(" {\n"); - if (ftor) { - aWriter.write("public " + className + "(JexlContext ctxt) {\n"); - aWriter.write(ctorBody); - aWriter.write(" }\n"); + try (final FileWriter writer = new FileWriter(new File(packageDir, sourceName), false)) { + writer.write("package "); + writer.write(GEN_PACKAGE); + writer.write(";\n"); + if (ftor) { + writer.write("import " + JEXL_PACKAGE + ".JexlContext;"); + writer.write(";\n"); + } + writer.write("public class " + className); + writer.write(" {\n"); + if (ftor) { + writer.write("public " + className + "(JexlContext ctxt) {\n"); + writer.write(ctorBody); + writer.write(" }\n"); + } + writer.write("private int value ="); + writer.write(Integer.toString(seed)); + writer.write(";\n"); + writer.write(" public void setValue(int v) {"); + writer.write(" value = v;"); + writer.write(" }\n"); + writer.write(" public int getValue() {"); + writer.write(" return value;"); + writer.write(" }\n"); + writer.write(" }\n"); + writer.flush(); } - aWriter.write("private int value ="); - aWriter.write(Integer.toString(seed)); - aWriter.write(";\n"); - aWriter.write(" public void setValue(int v) {"); - aWriter.write(" value = v;"); - aWriter.write(" }\n"); - aWriter.write(" public int getValue() {"); - aWriter.write(" return value;"); - aWriter.write(" }\n"); - aWriter.write(" }\n"); - aWriter.flush(); - aWriter.close(); } // Class<?> compile0() throws Exception { diff --git a/src/test/java/org/apache/commons/jexl3/ScriptTest.java b/src/test/java/org/apache/commons/jexl3/ScriptTest.java index 9fcd8beb..1f16d870 100644 --- a/src/test/java/org/apache/commons/jexl3/ScriptTest.java +++ b/src/test/java/org/apache/commons/jexl3/ScriptTest.java @@ -209,12 +209,12 @@ public class ScriptTest extends JexlTestCase { @Override public void handle(HttpExchange httpExchange) throws IOException { if ("POST".equals(httpExchange.getRequestMethod())) { - OutputStream outputStream = httpExchange.getResponseBody(); - String json = responder.apply(httpExchange); - httpExchange.sendResponseHeaders(200, json.length()); - outputStream.write(json.toString().getBytes()); - outputStream.flush(); - outputStream.close(); + try (OutputStream outputStream = httpExchange.getResponseBody()) { + String json = responder.apply(httpExchange); + httpExchange.sendResponseHeaders(200, json.length()); + outputStream.write(json.toString().getBytes()); + outputStream.flush(); + } } else { // error httpExchange.sendResponseHeaders(500, 0);
