[commons-crypto] branch master updated: Validate return value from OpenSslNativeJna.ENGINE_finish().

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git


The following commit(s) were added to refs/heads/master by this push:
     new e820943  Validate return value from OpenSslNativeJna.ENGINE_finish().
e820943 is described below

commit e8209437c562fdf9c777826b428582cb63ad3d48
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Mon Dec 12 17:55:14 2022 -0500

    Validate return value from OpenSslNativeJna.ENGINE_finish().
---
 src/changes/changes.xml                                                 | 1 +
 src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 360988a..311c3a3 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -75,6 +75,7 @@
       <action                    type="fix" dev="ggregory" due-to="Gary 
Gregory">PositionedCryptoInputStream does not close its CryptoCipher 
instances.</action>
       <action issue="CRYPTO-160" type="fix" dev="ggregory" due-to="Gary 
Gregory">Package-private class JavaCryptoRandom extends Random but should 
not.</action>
       <action                    type="fix" dev="ggregory" due-to="Gary 
Gregory">Validate return value from 
OpenSslNativeJna.EVP_CIPHER_CTX_set_padding().</action>
+      <action                    type="fix" dev="ggregory" due-to="Gary 
Gregory">Validate return value from OpenSslNativeJna.ENGINE_finish().</action>
       <!-- ADD -->
       <action                    type="fix" dev="ggregory" due-to="Gary 
Gregory, Dependabot">Add github/codeql-action 2 #159.</action>
       <action                    type="fix" dev="ggregory" due-to="Gary 
Gregory, Dependabot">Add AES utility class.</action>
diff --git 
a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java 
b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
index f587c00..4604aab 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
+++ b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
@@ -133,7 +133,7 @@ final class OpenSslJnaCryptoRandom implements CryptoRandom {
     private void closeRdrandEngine() {
 
         if (rdrandEngine != null) {
-            OpenSslNativeJna.ENGINE_finish(rdrandEngine);
+            throwOnError(OpenSslNativeJna.ENGINE_finish(rdrandEngine));
             OpenSslNativeJna.ENGINE_free(rdrandEngine);
         }
     }