This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new 2b035580 Make instance variable final
2b035580 is described below

commit 2b03558084e5ee9a1aa721007d7ab13a4e1315e5
Author: Gary Gregory <[email protected]>
AuthorDate: Wed Feb 8 14:10:59 2023 -0500

    Make instance variable final
---
 .../apache/commons/beanutils2/locale/BaseLocaleConverter.java  | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java 
b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
index 6e035eb4..11ca86e6 100644
--- 
a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
+++ 
b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
@@ -46,7 +46,7 @@ public abstract class BaseLocaleConverter<T> implements 
LocaleConverter<T> {
     protected boolean useDefault;
 
     /** The locale specified to our Constructor, by default - system locale. */
-    protected Locale locale = Locale.getDefault();
+    protected final Locale locale;
 
     /** The default pattern specified to our Constructor, if any. */
     protected String pattern;
@@ -116,16 +116,12 @@ public abstract class BaseLocaleConverter<T> implements 
LocaleConverter<T> {
      * @param locPattern    Indicate whether the pattern is localized or not
      */
     private BaseLocaleConverter(final Object defaultValue, final Locale locale,
-                                final String pattern, final boolean 
useDefault, final boolean locPattern) {
+            final String pattern, final boolean useDefault, final boolean 
locPattern) {
         if (useDefault) {
             this.defaultValue = defaultValue;
             this.useDefault = true;
         }
-
-        if (locale != null) {
-            this.locale = locale;
-        }
-
+        this.locale = locale != null ? locale : Locale.getDefault();
         this.pattern = pattern;
         this.locPattern = locPattern;
     }

Reply via email to