This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
commit 0e92f995040ca96aa4feb9416802c19af97d3ca5 Author: Gary Gregory <[email protected]> AuthorDate: Tue May 9 08:53:55 2023 -0400 Don't initialize to default value --- .../java/org/apache/commons/imaging/ImagingParameters.java | 4 ++-- .../commons/imaging/formats/png/PngImagingParameters.java | 4 ++-- .../commons/imaging/formats/pnm/PnmImagingParameters.java | 2 +- .../commons/imaging/formats/tiff/TiffImageMetadata.java | 2 +- .../commons/imaging/formats/tiff/TiffImagingParameters.java | 12 ++++++------ 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/main/java/org/apache/commons/imaging/ImagingParameters.java b/src/main/java/org/apache/commons/imaging/ImagingParameters.java index 4957ae63..696a0947 100644 --- a/src/main/java/org/apache/commons/imaging/ImagingParameters.java +++ b/src/main/java/org/apache/commons/imaging/ImagingParameters.java @@ -40,12 +40,12 @@ public class ImagingParameters<E extends ImagingParameters<E>> { * where a file name would be hard (or not possible) to be identified. * Default is {@code null}. */ - private String fileName = null; + private String fileName; /** * Factory to create {@code BufferedImage}s. Default is {@code null}. */ - private BufferedImageFactory bufferedImageFactory = null; + private BufferedImageFactory bufferedImageFactory; /** * <p>Parameter key. Used in write operations to indicate the desired pixel diff --git a/src/main/java/org/apache/commons/imaging/formats/png/PngImagingParameters.java b/src/main/java/org/apache/commons/imaging/formats/png/PngImagingParameters.java index 90440506..e5d0385f 100644 --- a/src/main/java/org/apache/commons/imaging/formats/png/PngImagingParameters.java +++ b/src/main/java/org/apache/commons/imaging/formats/png/PngImagingParameters.java @@ -46,14 +46,14 @@ public class PngImagingParameters extends XmpImagingParameters<PngImagingParamet * * @see org.apache.commons.imaging.formats.png.PhysicalScale */ - private PhysicalScale physicalScale = null; + private PhysicalScale physicalScale; /** * <p>Only used when writing Png images.</p> * * <p>Valid values: a list of WriteTexts.</p> */ - private List<? extends PngText> textChunks = null; + private List<? extends PngText> textChunks; public byte getBitDepth() { return bitDepth; diff --git a/src/main/java/org/apache/commons/imaging/formats/pnm/PnmImagingParameters.java b/src/main/java/org/apache/commons/imaging/formats/pnm/PnmImagingParameters.java index 65f9c4eb..4020aa5b 100644 --- a/src/main/java/org/apache/commons/imaging/formats/pnm/PnmImagingParameters.java +++ b/src/main/java/org/apache/commons/imaging/formats/pnm/PnmImagingParameters.java @@ -29,7 +29,7 @@ public class PnmImagingParameters extends ImagingParameters<PnmImagingParameters /** * Pnm format subtype (e.g. pam, pbm, etc). */ - private ImageFormats subtype = null; + private ImageFormats subtype; public ImageFormats getSubtype() { return subtype; diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageMetadata.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageMetadata.java index 2efdbe1e..55270e17 100644 --- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageMetadata.java +++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageMetadata.java @@ -51,7 +51,7 @@ import org.apache.commons.imaging.formats.tiff.write.TiffOutputSet; public class TiffImageMetadata extends GenericImageMetadata { public static class Directory extends GenericImageMetadata implements ImageMetadataItem { - // private BufferedImage thumbnail = null; + // private BufferedImage thumbnail; public final int type; diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImagingParameters.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImagingParameters.java index 8823a244..f0b9d792 100644 --- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImagingParameters.java +++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImagingParameters.java @@ -37,7 +37,7 @@ public class TiffImagingParameters extends XmpImagingParameters<TiffImagingParam * User provided {@code TiffOutputSet} used to write into * the image's metadata including standard directory and EXIF tags. */ - private TiffOutputSet tiffOutputSet = null; + private TiffOutputSet tiffOutputSet; /** * X-coordinate of a sub-image. @@ -67,19 +67,19 @@ public class TiffImagingParameters extends XmpImagingParameters<TiffImagingParam * <p>The value supplied with this key should be a valid instance of * a class that implements PhotometricInterpreter.</p> */ - private PhotometricInterpreter customPhotometricInterpreter = null; + private PhotometricInterpreter customPhotometricInterpreter; /** * TIFF compression algorithm, if any. */ - private Integer compression = null; + private Integer compression; /** * Specifies the amount of memory in bytes to be used for a strip * or tile size when employing LZW compression. The default is * 8000 (roughly 8K). Minimum value is 8000. */ - private Integer lzwCompressionBlockSize = null; + private Integer lzwCompressionBlockSize; /** * Used in write operations to indicate the desired T.4 options to @@ -89,7 +89,7 @@ public class TiffImagingParameters extends XmpImagingParameters<TiffImagingParam * TIFF_FLAG_T4_OPTIONS_2D, TIFF_FLAG_T4_OPTIONS_UNCOMPRESSED_MODE, * and TIFF_FLAG_T4_OPTIONS_FILL flags.</p> */ - private Integer t4Options = null; + private Integer t4Options; /** * Used in write operations to indicate the desired T.6 options to @@ -98,7 +98,7 @@ public class TiffImagingParameters extends XmpImagingParameters<TiffImagingParam * <p>Valid values: any Integer containing either zero or * TIFF_FLAG_T6_OPTIONS_UNCOMPRESSED_MODE.</p> */ - private Integer t6Options = null; + private Integer t6Options; /** * Clears settings for sub-image. Subsequent read operations will retrieve
