[ 
https://issues.apache.org/jira/browse/COMDEV-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478807#comment-15478807
 ] 

Sebb commented on COMDEV-203:
-----------------------------

There are still quite a few manually entered dates which were not added as UTC 
(i.e. the time component is not zero).

It's not always obvious whether to round the timestamp down or up; both GMT+12 
and GMT-12 will have a time component of 12 hours; similarly for GMT+13 and 
GMT-11 etc. However geographically it is most likely that hours greater than 12 
will correspond to zones west of Greenwich.

In some cases the JIRA dates and manual dates cannot be reconciled as they are 
more than 24 hours apart.

> Timezone issues with release dates
> ----------------------------------
>
>                 Key: COMDEV-203
>                 URL: https://issues.apache.org/jira/browse/COMDEV-203
>             Project: Community Development
>          Issue Type: Bug
>          Components: Reporter Tool
>            Reporter: Sebb
>
> Release dates are stored as seconds since the epoch in the 
> data/release/committe.json files. In theory all the dates should convert to 
> midnight UTC on the release date.
> If dates are obtained from JIRA, they are converted using the Python method 
> time.mktime() which uses the local timezone. This is done on the reporter.a.o 
> host, which is currently running UTC. However the host was originally set up 
> in a different timezone, so some of the dates don't convert to midnight. It 
> should have used calendar.gmtime() instead.
> If the dates are obtained from the user, then the YYYY-MM-DD string is 
> converted using Javascript using (new Date(yyyy,mm,dd)).getTime() which 
> assumes the local timezone. The converted value is passed back as an integer 
> to the python script. It should use Date.UTC(yyyy,mm,dd) instead. Or it could 
> pass back the date string for conversion by the Python code.
> It's easy enough to fix new dates going forward.
> However there are existing dates that will need correction.
> The dates are all converted assuming a local time of midnight, so when they 
> are converted back again, the local time offset will show up as a number of 
> hours since midnight. This can be used to adjust the value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to