Dear Wiki user, You have subscribed to a wiki page or wiki category on "Cordova Wiki" for change notification.
The "CommitterWorkflow" page has been changed by AndrewGrieve: https://wiki.apache.org/cordova/CommitterWorkflow?action=diff&rev1=19&rev2=20 * The issues are also used to track which commits / topic branches are related to them. == Step 3: Create a topic branch == + * Using a public topic branch is necessary only when you would like to collaborate on the feature. - * Using a public topic branch is necessary only when either: - 1. you would like to collaborate on the feature - 1. you would like feedback on your code before committing - * For small bugfixes, public topic branches are not required. + * For small changes, private topic branches are preferred. * Note: You should never rebase a public topic branch! == Step 4: Ask for a code review == * If you are using a public topic branch, then you should ask for a code review when you consider it to be complete. - * For now, use a github pull request. Soon, use [[http://reviews.apache.org/|reviews.apache.org]]. - * Email the ML so that anyone who is available can have a look at your code. If you have someone in particular that you would like approval from, be sure to add them in the To: of your email. - * Again, sometimes this will end with a [[http://www.apache.org/foundation/glossary.html#LazyConsensus|Lazy Consensus]]. + * Use [[http://reviews.apache.org/|reviews.apache.org]] to create a review request. + * By default, the ML will be notified of your review request. + * If you have someone in particular that you would like approval from, be sure to add them in "People" field of the review. == Step 5: Merge your change == * Once your topic branch is tested & working, it's time to merge it.
