Dear Wiki user, You have subscribed to a wiki page or wiki category on "Cordova Wiki" for change notification.
The "CommitterWorkflow" page has been changed by MichalMocny: https://wiki.apache.org/cordova/CommitterWorkflow?action=diff&rev1=28&rev2=29 * If your change adds a new feature, or makes a non-backwards-compatible change, please note it in the commit description! === Step 5: Test your changes === - * You are responsible for testing the changes that push. + * You are responsible for testing the changes that you push. * This includes: * All automated tests in mobile-spec * Manual tests in mobile-spec that might be affected by the change @@ -64, +64 @@ === Step 6: Ask for a code review (''optional'') === * Do this if you want a second pair of eyes to look at your code before it goes in. * Use [[http://reviews.apache.org/|reviews.apache.org]] to create a review request. - * Easiest way is to use type [[http://www.reviewboard.org/docs/rbtools/dev/|post-review]] from the repo with the change. + * Easiest way is to use [[http://www.reviewboard.org/docs/rbtools/dev/|post-review]] from the repo with the change. * By default, the ML will be notified of your review request. * If you have someone in particular that you would like approval from, be sure to add them in "People" field of the review. @@ -102, +102 @@ {{{ git checkout 2.9.x git cherry-pick -x COMMIT_HASH # the -x flag adds "cherry-picked from <commit>" to the commit messages - git push apache 2.9.x + git push origin 2.9.x }}} The `git rebase -i` step is your chance to clean up the commit messages and to combine small commits when appropriate. For example:
