Repository: cordova-app-harness
Updated Branches:
  refs/heads/master 736c8d1de -> c8fdd7ca1


CB-6975 Improve the speed of the zip function


Project: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/cordova-app-harness/commit/c8fdd7ca
Tree: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/tree/c8fdd7ca
Diff: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/diff/c8fdd7ca

Branch: refs/heads/master
Commit: c8fdd7ca19699a0c7852f989d65a334fd0082ab2
Parents: 736c8d1
Author: David Kemp <[email protected]>
Authored: Wed Jun 18 16:33:46 2014 -0400
Committer: David Kemp <[email protected]>
Committed: Wed Jun 18 16:33:46 2014 -0400

----------------------------------------------------------------------
 harness-push/node_modules/cordova-harness-client/pushsession.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-app-harness/blob/c8fdd7ca/harness-push/node_modules/cordova-harness-client/pushsession.js
----------------------------------------------------------------------
diff --git a/harness-push/node_modules/cordova-harness-client/pushsession.js 
b/harness-push/node_modules/cordova-harness-client/pushsession.js
index 95d8a45..1b0e9c0 100644
--- a/harness-push/node_modules/cordova-harness-client/pushsession.js
+++ b/harness-push/node_modules/cordova-harness-client/pushsession.js
@@ -174,7 +174,7 @@ function zipDir(dir, zip) {
                 var inner = zip.folder(f);
                 zipDir(path.join(dir, f), inner);
             } else {
-                zip.file(f, fs.readFileSync(fullPath, 'binary'), { binary: 
true });
+                zip.file(f, fs.readFileSync(fullPath, 'base64'), { binary: 
true, optimizedBinaryString: true });
             }
         }
     });
@@ -296,7 +296,7 @@ PushSession.prototype.doZipPush_ = function(pushList, 
startTime) {
     }
     var zipAssetManifest = buildZipAssetManifest(pushList);
     zip.file('zipassetmanifest.json', JSON.stringify(zipAssetManifest));
-    var zipData = new Buffer(zip.generate({ type: 'base64' }), 'base64');
+    var zipData = zip.generate({ type: 'nodebuffer' });
     var self = this;
     return this.harnessClient_.pushZip(this.appId_, this.appType_, zipData, 
null, this.assetManifestEtag_)
     .then(function(newAssetManifestEtag) {

Reply via email to