Make windows exception more human readable
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/commit/3d8a5c13 Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/tree/3d8a5c13 Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/diff/3d8a5c13 Branch: refs/heads/master Commit: 3d8a5c13980e39f6425d40bac0a2f1ae558a4e0f Parents: 6861386 Author: SomaticIT <[email protected]> Authored: Tue Oct 7 18:14:13 2014 +0200 Committer: SomaticIT <[email protected]> Committed: Tue Oct 7 18:14:13 2014 +0200 ---------------------------------------------------------------------- www/FileWriter.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/blob/3d8a5c13/www/FileWriter.js ---------------------------------------------------------------------- diff --git a/www/FileWriter.js b/www/FileWriter.js index 68315fd..f009107 100644 --- a/www/FileWriter.js +++ b/www/FileWriter.js @@ -99,12 +99,11 @@ FileWriter.prototype.write = function(data) { var that=this; var supportsBinary = (typeof window.Blob !== 'undefined' && typeof window.ArrayBuffer !== 'undefined'); + var isOkForWindows = (cordova.platformId === "windows8" || cordova.platformId === "windows") && (data instanceof Blob || data instanceof File); var isBinary; - var isWin8 = cordova.platformId === "windows8" || cordova.platformId === "windows"; // Check to see if the incoming data is a blob - if ((!isWin8 || !(data instanceof Blob || data instanceof File)) && // ignore if Windows 8 - (data instanceof File || (supportsBinary && data instanceof Blob))) { + if (!isOkForWindows && (data instanceof File || (supportsBinary && data instanceof Blob))) { var fileReader = new FileReader(); fileReader.onload = function() { // Call this method again, with the arraybuffer as argument @@ -120,7 +119,7 @@ FileWriter.prototype.write = function(data) { // Mark data type for safer transport over the binary bridge isBinary = supportsBinary && (data instanceof ArrayBuffer); - if (isBinary && ['windowsphone', 'windows8'].indexOf(cordova.platformId) >= 0) { + if (isBinary && cordova.platformId === "windowsphone") { // create a plain array, using the keys from the Uint8Array view so that we can serialize it data = Array.apply(null, new Uint8Array(data)); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
