todos and other minor tweaks.

Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/7f569506
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/7f569506
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/7f569506

Branch: refs/heads/master
Commit: 7f56950672794743b49635b472880a840b4025fe
Parents: 750b2f7
Author: filmaj <[email protected]>
Authored: Fri Feb 10 12:10:19 2017 -0800
Committer: filmaj <[email protected]>
Committed: Tue Apr 25 17:28:07 2017 -0700

----------------------------------------------------------------------
 src/create-verify-archive.js | 1 +
 src/plugin-release.js        | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/7f569506/src/create-verify-archive.js
----------------------------------------------------------------------
diff --git a/src/create-verify-archive.js b/src/create-verify-archive.js
index 99d6382..e761690 100644
--- a/src/create-verify-archive.js
+++ b/src/create-verify-archive.js
@@ -127,6 +127,7 @@ function *createArchive(repo, tag, outDir, sign) {
         fs.writeFileSync(outPath + '.md5', (yield computeHash(outPath, 'MD5')) 
+ '\n');
         fs.writeFileSync(outPath + '.sha', (yield computeHash(outPath, 
'SHA512')) + '\n');
     }
+    return outPath;
 }
 
 exports.createArchive = createArchive;

http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/7f569506/src/plugin-release.js
----------------------------------------------------------------------
diff --git a/src/plugin-release.js b/src/plugin-release.js
index 75e5bb9..0559595 100644
--- a/src/plugin-release.js
+++ b/src/plugin-release.js
@@ -63,6 +63,7 @@ var plugins_ommitted = []; // array of plugin names that DO 
NOT need releasing
 
 function *interactive_plugins_release() {
     console.log('Hi! So you want to do a plugins release, do you?');
+    // TODO: run a shelljs.which(gpg) to make sure RM has gpg on their path
     console.log('Let\'s start with your JIRA credentials - this system will be 
interacting with Apache\'s JIRA instance (issues.apache.org) often.');
     inquirer.prompt([{
         type: 'input',
@@ -561,11 +562,11 @@ function *interactive_plugins_release() {
                     var plugin_name = repo.repoName;
                     var tag = plugin_data[plugin_name].current_release;
                     yield gitutil.gitCheckout(tag);
-                    yield create_archive.createArchive(repo, tag, 
dist_dev_dir, true/*sign*/);
+                    var archive = yield create_archive.createArchive(repo, 
tag, dist_dev_dir, true/*sign*/);
                 });
             })();
-            //   - "manually double check version numbers are correct on the 
file names"
             //   - verify-archive cordova-dist-dev/$JIRA/*.tgz
+            //     - needs refactor of verify method
             //   - upload by running `svn` commands.
         });
     }, function(auth_err) {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to