filmaj commented on issue #393: Fix for Jira issue CB-12981 URL: https://github.com/apache/cordova-android/pull/393#issuecomment-329304589 Just want to confirm @tensberg's conclusion, I can repro the same thing. We'll need to change the code to be able to deal with both ways that the Android SDK describes the API level of AVDs, using either the numeric API ID (i.e. Android API 26) or the Android version string (i.e. Android 8.0). Since `list_images_using_xxx` is only used 'internally' in `emulator.js`, and all other scripts use `list_images` (which itself calls into either leveraging the `android` or the `avdmanager` binaries, depending on what's available), I suggest having `list_images` massage the parsed list of AVDs and fill in any missing info re: API level / Android version. I'll whip up a proof of concept and issue a new PR for that, and we can move discussion there. I'll also add @tensberg's updated output above as a unit test case to ensure the new code works with both kinds of output. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
