chancezeus commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-331628391 Why require the bundleIdentifier to be entered inside the build.json file, since it is already available in config.xml and *-Info.plist Wouldn't it be better to do it like this: add: `var projectFile = require('./projectFile');` on line 29 add: `var self = this;` on line 58 add: ``` var project = projectFile.parse(self.locations); var pkgName = project.getPackageName(); if (pkgName && buildOpts.provisioningProfile) { exportOptions.provisioningProfiles = {[pkgName]: buildOpts.provisioningProfile}; exportOptions.signingStyle = 'manual'; } if (buildOpts.codeSignIdentity) { exportOptions.signingCertificate = buildOpts.codeSignIdentity; } ``` on line 141 This automatically extracts the packageName (ie. bundleIdentifier) from the *-Info.plist and uses that instead of requiring the developer to add it to the build.json ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
