filmaj opened a new pull request #410: CB-13404, CB-13406: `best_image` function fixes when choosing emulator images to deploy to URL: https://github.com/apache/cordova-android/pull/410 This PR addresses both [CB-13404](https://issues.apache.org/jira/browse/CB-13404) and [CB-13406](https://issues.apache.org/jira/browse/CB-13406). Summary of changes: - added tests to the `best_image` method of the emulator command line scripts. - when comparing project and AVD API levels, sub-optimal matches of the API level would lead to incoherent results for `best_image` since we were applying integer comparisons on strings. - added required module `android-versions` to `bundledDependencies` - bumped `android-versions` to 1.2.1 to fix issues when converting API levels and Android semver strings for Android 8. ### What testing has been done on this change? Ran automated tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
