[GitHub] dpa99c commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

[GitBox]

dpa99c commented on issue #246: Cb 13409 - Add more configurable options for 
toolbar in android and ios
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-346459319
 
 
   @steinaragustli I've extended your PR in [a 
fork](https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/CB-13409) 
to [add support to Android for a footer close button similar to the iOS "Done" 
button](https://github.com/dpa99c/cordova-plugin-themeablebrowser/commit/abffd004ee4240c1c25adc060633027405faa788).
   
   Once your PR is merged, I'll create a JIRA issue and submit this as a 
separate PR.
   
   Here's some screenshots with the relevant options:
   
   `location=yes,footer=yes`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png"/>
   
   `location=no,footer=yes`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png"/>
   
   `location=yes,footer=yes,closebuttoncaption=Done`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png"/>
   
   `location=yes,footer=yes,closebuttoncaption=Done`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147256-03bd4018-cfbf-11e7-9994-eebbe52755e0.png"/>
   
   `location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#0000ff`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png"/>
   
   `location=no,footer=yes,footercolor=#0000ff,closebuttoncaption=Done`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png"/>
   
   
`location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#0000ff`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png"/>
   
   
`location=no,footer=yes,footercolor=#CC000000,closebuttoncaption=Done,closebuttoncolor=#00FFFF`
   <img width="300" 
src="https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png"/>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org