IndieSW commented on a change in pull request #244: CB-13641: (windows) allow
for transparent splash screen background co?
URL: https://github.com/apache/cordova-windows/pull/244#discussion_r155576718
##########
File path: cordova-js-src/splashscreen.js
##########
@@ -212,7 +215,7 @@ function exitFullScreen() {
// Make title bg color match splashscreen bg color
function colorizeTitleBar() {
var appView =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
- if (isWin10UWP) {
+ if (isWin10UWP && (typeof titleBgColor !== 'undefined')) {
Review comment:
That's a reasonable point. Both `titleBgColor` and `titleInitialBgColor` are
set in one place and used in one place. Adding a variable to track whether or
not `bgColor` is transparent seemed like too much. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
