dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358581115 @infil00p @stevengill @agrieve @shazron @purplecabbage How should I proceed with this? I have a fork of this plugin as [cordova-plugin-inappbrowser-wkwebview](https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview) which implements WKWebview for the InappBrowser for iOS. It's fairly battle-hardened now as it's being used by around 1/4 million users per month (both Android & iOS) in production apps. The implementation is based on @shazron's [apache/wkwebview](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview) branch from 2014, but I've committed it against a fork of [apache/master](https://github.com/apache/cordova-plugin-inappbrowser/tree/master) since this is much more update-to-date with respect to other platforms than [apache/wkwebview](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview). The current implementation drops support for the UIWebView implementation in favour of WKWebView, so relies on `cordova-plugin-wkwebview-engine` to be present in the project. Should I attempt to modify it to conditionally switch between the UIWebView and WKWebView implementations based on the presence of `cordova-plugin-wkwebview-engine`? I think it may be a fair amount of work to do this though...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
