jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt 
images using the Camera plugin c?
URL: 
https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-362273600
 
 
   I would use the same e.getMessage() or e.getLocalizedMessage() for both, not 
one with e.getMessage() and the other e.getLocalizedMessage() (for consistency).
   
   I've checked other plugins and cordova-plugin-file uses 
e.getLocalizedMessage(), so I would use e.getLocalizedMessage() for both.
   
   The iOS file shows no changes, but appears as modified, so you should remove 
it from the PR, maybe with a git reset or something.
   
   Ah, and remove the comments, I think there is no need.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to