janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910928
 
 

 ##########
 File path: src/android/SplashScreen.java
 ##########
 @@ -307,12 +310,29 @@ public void run() {
 
                 // Create and show the dialog
                 splashDialog = new Dialog(context, 
android.R.style.Theme_Translucent_NoTitleBar);
-                // check to see if the splash screen should be full screen
+                splashWindow = splashDialog.getWindow();
+               // check to see if the splash screen should be full screen
                 if ((cordova.getActivity().getWindow().getAttributes().flags & 
WindowManager.LayoutParams.FLAG_FULLSCREEN)
                         == WindowManager.LayoutParams.FLAG_FULLSCREEN) {
-                    
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
+                    
splashWindow.setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
                             WindowManager.LayoutParams.FLAG_FULLSCREEN);
                 }
+
+                // Status bar color just like cordova-plugin.statusbar
+                String statusBarColor = 
preferences.getString("StatusBarBackgroundColor", "#000000");
 
 Review comment:
   This should probably be added to the README as well, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to