janpio commented on a change in pull request #170: CB-13828: Improve 
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170090965
 
 

 ##########
 File path: docs/platforms-release-process.md
 ##########
 @@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have 
Apache-compatible licenses.
     coho check-license -r android
 
 ## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev` 
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
 
     for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json | 
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting 
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; 
fi) ; done
 
-In `cordova-android`, also remember to bump the version in 
`framework/build.gradle`.
+Note: This command [doesn't actually 
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace 
`-dev` manually of course.
 
-If the changes merit it, manually bump the major / minor/ patch version in 
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in 
`framework/build.gradle`.
 
 Review comment:
   Is this good enough? I was somehow thinking there was a reason that "remove 
-dev" and the other version stuff later is split in 2 parts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to