dblotsky commented on a change in pull request #804: CB-13964 - 'Make' command
to build cordova website dont work in windows
URL: https://github.com/apache/cordova-docs/pull/804#discussion_r173881149
##########
File path: Makefile
##########
@@ -108,8 +108,8 @@ FETCH_SCRIPT = $(BIN_DIR)/fetch_docs.js
# which includes them on its own, and the SCSS compiler takes care of
them;
# because of this, there is also no .scss -> .css pattern rule
ifdef WINDOWS
-SCSS_SRC = $(subst $(PWD)/,,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir
*.scss /S /B)))
-STYLES_SRC = $(subst $(PWD)/,,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir
*.less *.css /S /B)))
+SCSS_SRC = $(subst $(dir $(realpath $(firstword $(MAKEFILE_LIST)))),,$(subst
\,/,$(shell cd $(CSS_SRC_DIR) && dir *.scss /S /B)))
+STYLES_SRC = $(subst $(dir $(realpath $(firstword $(MAKEFILE_LIST)))),,$(subst
\,/,$(shell cd $(CSS_SRC_DIR) && dir *.less *.css /S /B)))
Review comment:
Two comments:
1. It would be a bit more readable to put this computation into a variable
(e.g. `PWD` or `CWD`), like so:
CWD = $(dir $(realpath $(firstword $(MAKEFILE_LIST))))
SCSS_SRC = $(subst $(CWD),,$( ...
2. Alternatively, you can use the `pwd` command, which should be available
on Windows, like so:
PWD = $(shell pwd)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
