raphinesse commented on a change in pull request #458: Unit tests for
AndroidProject and Builders
URL: https://github.com/apache/cordova-android/pull/458#discussion_r198448072
##########
File path: spec/unit/AndroidProject.spec.js
##########
@@ -113,15 +113,15 @@ describe('AndroidProject', () => {
androidProject.getPackageName();
-
expect(AndroidManifestSpy).toHaveBeenCalledWith(`${PROJECT_DIR}/AndroidManifest.xml`);
+
expect(AndroidManifestSpy).toHaveBeenCalledWith(path.join(PROJECT_DIR,
'AndroidManifest.xml'));
Review comment:
That should go into the first commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
