Menardi commented on issue #458: Unit tests for AndroidProject and Builders URL: https://github.com/apache/cordova-android/pull/458#issuecomment-400867223 Thanks for all your feedback. It sounds like all the three builders could be made in to one. At that point do we still need `builder.js`, which is the intermediary that returns the requested builder? I'm not sure if its use is only within `cordova-android`, or if `builders.getBuilder` is a more general Cordova spec. If it's not needed, then all of these files could be brought into a single file (`ProjectBuilder.js`), which would certainly make it a lot easier to understand. As for the testing, I mentioned that I would like to fully cover the builders, but I don't have a good `project.properties` file to write the tests around. Do any of you have an example file with many entries, which I could use?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
