raphinesse commented on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-401536021 Thanks for your Analysis. Looking at the issue this is supposed to fix, I wonder if removing the default memory setting is the right thing here. The way I see it, we would be improving support for 32 bit JVMs while worsening the situation for large projects. That does not sound like a good deal to me. Is 32bit Java support even relevant? If so, IMHO the best thing would be detecting it and limit the heap size accordingly. However, we probably need the check_reqs cleanup that I put on the roadmap for next major first. Does that make sense or am I getting something wrong?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
