erisu edited a comment on issue #392: Pin jasmine@3.1.0
URL: https://github.com/apache/cordova-ios/pull/392#issuecomment-412110333
 
 
   @brodybits The questions I have: 
   - Do we merge this temporary fix so master is green while we can continue to 
research into Jasmine 3.2.0? 
   - Do you have any issues if this was merged in?
   
   The problem could be that these tests have always been broken and with the 
new Jasmine release, it bubbled up the issue. The last PR does not affect 
actual code; it only added new tests and updated testing deps (Jasmine, Rewire, 
and added NYC).
   
   The other possibility is that Jasmine actually introduced a bug and the 
tests are OK. If the tests are updated to work with the possible new bug, it is 
likely that the tests will fail again once Jasmine releases a new version.
   
   Either way, I don't deny that we should investigate to find out where the 
issues originate and correct if it's our tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to