IndieSW commented on issue #160: Feature request: Add background color for iOS and Android URL: https://github.com/apache/cordova-plugin-splashscreen/issues/160#issuecomment-424129336 See PR: https://github.com/apache/cordova-plugin-splashscreen/pull/161 Github diff wasn't very kind. To summarize the changes: - a SplashScreenThemeId preference is initialized in pluginInitialize() and defaults to the previously hardcoded value. this follows the way drawableId is handled. - isActivityFullScreen() was added with logic removed from showSplashScreen(). - in showSplashScreen() - before the Runnable: - int themeId is set to the SplashScreenThemeId preference value. - int backgroundColor is set according to the SplashScreenBackgroundColor preference and defaults to the previously hardcoded value. - in showSplashScreen() - in the Runnable: - the background color of the ImageView is set to int backgroundColor. - the Dialog is created with int themeId. - isActivityFullScreen() is used to decide whether to add FLAG_FULLSCREEN to the Dialog Window LayoutParams. Hope that helps. Please let me know if you have any questions. Also, the changes were made to version 4.0.4-dev according to the plugin.xml. I'm not sure which commit that corresponds to.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
