janpio commented on a change in pull request #159: iPhone XR, XS, XSMax Support
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/159#discussion_r221582546
##########
File path: src/ios/CDVSplashScreen.m
##########
@@ -175,7 +181,8 @@ - (CDV_iOSDevice) getCurrentDevice
device.iPhone6 = (device.iPhone && limit == 667.0);
device.iPhone6Plus = (device.iPhone && limit == 736.0);
device.iPhoneX = (device.iPhone && limit == 812.0);
-
+ device.iPhoneXSMax = (device.iPhone && limitNativ == 2688.0);
Review comment:
this is also the reason why tests are failing on Travis for iOS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
