janpio commented on issue #242: CB-11714: (windows) added check for encoding in 
savePhoto() without height/width
URL: 
https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426043765
 
 
   Thanks @DisruptiveMind.
   
   Tests are now failing because of
   ```
   /Users/travis/build/apache/cordova-plugin-camera/src/windows/CameraProxy.js
     790:67  error  Strings must use singlequote  quotes
   ✖ 1 problem (1 error, 0 warnings)
     1 error, 0 warnings potentially fixable with the `--fix` option.
   ```
   This doesn't make too much sense to me, especially as line 790 contains no 
quotes at all.
   
   Can you maybe rebase on `master`? I hope this will go away with more recent 
test configuration. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to