This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git
The following commit(s) were added to refs/heads/master by this push:
new dfed2c7 Fix inappbrowser on Android 7 (#50)
dfed2c7 is described below
commit dfed2c716bfaf1c9bfde2fba5c073d8e0685d7af
Author: Jan Piotrowski <[email protected]>
AuthorDate: Tue Oct 2 21:27:34 2018 +0200
Fix inappbrowser on Android 7 (#50)
Android 7.0 tests were failing for `cordova-plugin-inappbrowser`:
https://github.com/apache/cordova-plugin-inappbrowser/issues/307 Long research
showed that this had to do with the permission buster hanging.
Lo and behold, here we have code for not make a plugin hang on Android 7.
Let's add the inappbrowser plugin to this check and see if this fixes
things.
Closes https://github.com/apache/cordova-plugin-inappbrowser/issues/307
---
lib/paramedic.js | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/paramedic.js b/lib/paramedic.js
index 1c4d642..a386bb7 100644
--- a/lib/paramedic.js
+++ b/lib/paramedic.js
@@ -984,17 +984,20 @@ ParamedicRunner.prototype.runSauceTests = function () {
var platform = self.config.getPlatformId();
var plugins = self.config.getPlugins();
+
var skipBuster = false;
- // skip permission buster for splashscreen plugin
+ // skip permission buster for splashscreen and inappbrowser plugins
// it hangs the test run on Android 7 for some reason
for (var i = 0; i < plugins.length; i++) {
- if (plugins[i].indexOf('cordova-plugin-splashscreen') >= 0) {
+ if (plugins[i].indexOf('cordova-plugin-splashscreen') >= 0 ||
plugins[i].indexOf('cordova-plugin-inappbrowser') >= 0) {
skipBuster = true;
}
}
+ // always skip buster for browser platform
if (platform === util.BROWSER) {
skipBuster = true;
}
+
if (!self.config.getUseTunnel()) {
var polling = false;
pollForResults = setInterval(function () {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
