janpio closed pull request #275: CB-14190: (windows) Fix bug where double
clicking `<select>` exits app
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/windows/InAppBrowserProxy.js b/src/windows/InAppBrowserProxy.js
index 9e544c5d0..1af6b95f8 100644
--- a/src/windows/InAppBrowserProxy.js
+++ b/src/windows/InAppBrowserProxy.js
@@ -159,10 +159,12 @@ var IAB = {
// Save body overflow style to be able to reset it back
later
bodyOverflowStyle = document.body.style.msOverflowStyle;
- browserWrap.onclick = function () {
- setTimeout(function () {
- IAB.close(navigationEventsCallback);
- }, 0);
+ browserWrap.onclick = function (e) {
+ if (e.target !== popup) {
+ setTimeout(function () {
+ IAB.close(navigationEventsCallback);
+ }, 0);
+ }
};
document.body.appendChild(browserWrap);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
