brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix)
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437479222
 
 
   I just updated with a simple solution: do not do the path remapping if 
target-dir="app/lib" in source-file element. CB-14125 is no longer reverted in 
this proposal.
   
   Since use of target-dir="app/lib" indicates that the plugin is using the new 
file structure, I think there should be no reason to mess with it.
   
   I think this should not break anything. If I am mistaken a specific case 
would be really helpful.
   
   An even simpler solution may be to not do the path remapping if the 
target-dir starts with "app".
   
   Test case is still needed for uninstall case. I can work on it over the 
weekend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to