rtpHarry commented on a change in pull request #619: javac error message fixes 
in requirements check
URL: https://github.com/apache/cordova-android/pull/619#discussion_r248364947
 
 

 ##########
 File path: bin/templates/cordova/lib/check_reqs.js
 ##########
 @@ -204,9 +204,11 @@ module.exports.check_java = function () {
             }, () => {
                 var msg =
                 'Failed to run "javac -version", make sure that you have a JDK 
installed.\n' +
 
 Review comment:
   Should it specifically say v8 / 1.8.* in this line as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to