This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
     new e41fbc5  javac error message fixes in requirements check (#619)
e41fbc5 is described below

commit e41fbc57087c836a4930eb5dc14c1e1c6d954fc8
Author: Chris Brody <[email protected]>
AuthorDate: Wed Jan 16 22:51:45 2019 -0500

    javac error message fixes in requirements check (#619)
    
    - fix download link
    - put download link on its own line
    - no punctuation at the end of the download link
      (fixes #618)
    - no extra newline at the end
    - extra newline spacing in case JAVA_HOME is invalid
---
 bin/templates/cordova/lib/check_reqs.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/bin/templates/cordova/lib/check_reqs.js 
b/bin/templates/cordova/lib/check_reqs.js
index 95ef89f..ec94022 100644
--- a/bin/templates/cordova/lib/check_reqs.js
+++ b/bin/templates/cordova/lib/check_reqs.js
@@ -204,9 +204,11 @@ module.exports.check_java = function () {
             }, () => {
                 var msg =
                 'Failed to run "javac -version", make sure that you have a JDK 
installed.\n' +
-                'You can get it from: 
http://www.oracle.com/technetwork/java/javase/downloads.\n';
+                'You can get it from the following location:\n' +
+                
'https://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html';
                 if (process.env['JAVA_HOME']) {
-                    msg += 'Your JAVA_HOME is invalid: ' + 
process.env['JAVA_HOME'] + '\n';
+                    msg += '\n\n';
+                    msg += 'Your JAVA_HOME is invalid: ' + 
process.env['JAVA_HOME'];
                 }
                 throw new CordovaError(msg);
             });


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to