janpio commented on a change in pull request #624: Add missing log to Java
version check
URL: https://github.com/apache/cordova-android/pull/624#discussion_r248821325
##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -355,16 +355,16 @@ module.exports.check_android_target = function
(originalError) {
// Returns a promise.
module.exports.run = function () {
return Q.all([this.check_java(), this.check_android()]).then(function
(values) {
- console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
- console.log('JAVA_HOME=' + process.env['JAVA_HOME']);
Review comment:
I think this is misleading: Isn't it actually the output of `javac -version`
that defines the version that is used for comparison? What exactly does the
code _do_ with `JAVA_HOME` there? Is this just for the final comparison at
https://github.com/apache/cordova-android/blob/d9c08f12a7bceb47ee97ca8ca0e75548e78f999d/bin/templates/cordova/lib/check_reqs.js#L209-L212?
Why is `JAVA_HOME` relevant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
