erisu opened a new pull request #673: Updated ANDROID_HOME Test to Follow #656 
Change
URL: https://github.com/apache/cordova-android/pull/673
 
 
   ### Platforms affected
   none
   
   ### Motivation and Context
   There was a change in how the export var ANDROID_HOME is being set to follow 
Android documentation. 
   
   The existing tests which tested an alternative way of find ANDROID_HOME on 
top of what is in Android documentation were not updated.
   
   The changes were valid and follows Android's documentation, therefore 
updating the tests were the appropriate solution.
   
   
   ### Testing
   - Local Testing
   - CI Testing
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to