timbru31 commented on issue #132: WIP: feat: update typings URL: https://github.com/apache/cordova-plugin-statusbar/pull/132#issuecomment-465269176 Yes it adds a mandatory release step, but the user is able to see if the typings differ from the actual npm release - this could save some headache or searching. Because I've mostly worked with DefinitelyTyped, where it's needed for determining the version which is published to npm (see https://blogs.msdn.microsoft.com/typescript/2016/12/14/writing-dts-files-for-types/), I've kept it. I guess it has both some pros and cons keeping the version in the header file. Sidenote, if forgotten to increase the version it won't stop the typings from working, since it's a comment after all :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
