janpio commented on issue #540: Cordova iOS 5.0.0 can not build without `node_modules` present because of missing `shelljs` for build phase script URL: https://github.com/apache/cordova-ios/issues/540#issuecomment-465534912 Ok, talked to @Erisu a bit about this: There are multiple options to fix this: 1. Do what I said above and bring the dependencies back. Bad as you don't want to have bundled dependencies and all the problems that come with it. 2. We could change back the script from node to being a shell script, which it seems it was a few years ago (see https://github.com/apache/cordova-ios/blob/3.8.x/bin/templates/scripts/cordova/lib/copy-www-build-step.sh). Probably not the best idea, as there sure was a reason why we change it back then. 3. We can change the script from `shelljs` to something that comes with node, e.g. `child_process` and similar. As this script only runs on macOS, no need for cross platform support etc. So option 3 it is I guess.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
