[cordova-electron] branch master updated: Build Script Improvements (#27)

[erisu]

This is an automated email from the ASF dual-hosted git repository.

erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-electron.git


The following commit(s) were added to refs/heads/master by this push:
     new aaa3af1  Build Script Improvements (#27)
aaa3af1 is described below

commit aaa3af10f1eb1f96091008e7f4a19b12596de370
Author: Gedas Gardauskas <gedas.gardaus...@gmail.com>
AuthorDate: Thu Feb 21 21:03:05 2019 +0900

    Build Script Improvements (#27)
    
    - Add emits for better usability
    - Remove unused method argument
---
 bin/templates/cordova/lib/build.js | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/bin/templates/cordova/lib/build.js 
b/bin/templates/cordova/lib/build.js
index f005859..77574eb 100644
--- a/bin/templates/cordova/lib/build.js
+++ b/bin/templates/cordova/lib/build.js
@@ -19,6 +19,7 @@
 
 const fs = require('fs-extra');
 const path = require('path');
+const events = require('cordova-common').events;
 
 function deepMerge (mergeTo, mergeWith) {
     for (const property in mergeWith) {
@@ -58,7 +59,7 @@ class ElectronBuilder {
         return this;
     }
 
-    configureUserBuildSettings (buildOptions) {
+    configureUserBuildSettings () {
         if (this.buildConfig && this.buildConfig.electron) {
             let userBuildSettings = {};
 
@@ -152,7 +153,7 @@ class ElectronBuilder {
 
     __appendUserSingning (platform, signingConfigs, userBuildSettings) {
         if (platform === 'linux') {
-            // emit that there is no signing.
+            events.emit('warn', `The provided signing information for the 
Linux platform is ignored. Linux does not support signing.`);
             return this;
         }
 
@@ -188,28 +189,28 @@ class ElectronBuilder {
         if (entitlements && fs.existsSync(entitlements)) {
             buildConfigs.entitlements = entitlements;
         } else if (entitlements) {
-            // emit that the entitlement path is missing.
+            events.emit('warn', `The provided entitlements file does not exist 
in the given path => ${entitlements}`);
         }
 
         const entitlementsInherit = config.entitlementsInherit;
         if (entitlementsInherit && fs.existsSync(entitlementsInherit)) {
             buildConfigs.entitlementsInherit = entitlementsInherit;
         } else if (entitlementsInherit) {
-            // emit that the entitlement path is missing.
+            events.emit('warn', `The provided entitlements inherit file does 
not exist in the given path => ${entitlementsInherit}`);
         }
 
         const requirements = config.requirements;
         if (requirements && fs.existsSync(requirements)) {
             buildConfigs.requirements = requirements;
         } else if (requirements) {
-            // emit that the entitlement path is missing.
+            events.emit('warn', `The provided requirements file does not exist 
in the given path => ${requirements}`);
         }
 
         const provisioningProfile = config.provisioningProfile;
         if (provisioningProfile && fs.existsSync(provisioningProfile)) {
             buildConfigs.provisioningProfile = provisioningProfile;
         } else if (provisioningProfile) {
-            // emit that the provisioningProfile path is missing.
+            events.emit('warn', `The provided provisioning profile does not 
exist in the given path => ${provisioningProfile}`);
         }
     }
 
@@ -220,7 +221,7 @@ class ElectronBuilder {
 
             if (config.certificatePassword || process.env.CSC_KEY_PASSWORD) 
buildConfigs.certificatePassword = config.certificatePassword || 
process.env.CSC_KEY_PASSWORD;
         } else if (certificateFile) {
-            // emit that the certificateFile path is missing.
+            events.emit('warn', `The provided certificate file does not exist 
in the given path => ${certificateFile}`);
         }
 
         if (config.certificateSubjectName) buildConfigs.certificateSubjectName 
= config.certificateSubjectName;
@@ -231,7 +232,7 @@ class ElectronBuilder {
         if (additionalCertificateFile && 
fs.existsSync(additionalCertificateFile)) {
             buildConfigs.additionalCertificateFile = additionalCertificateFile;
         } else if (additionalCertificateFile) {
-            // emit that the additionalCertificateFile path is missing.
+            events.emit('warn', `The provided addition certificate file does 
not exist in the given path => ${additionalCertificateFile}`);
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org