mevinDhun opened a new pull request #501: Fixed corrupted image on ios 13 when using camera URL: https://github.com/apache/cordova-plugin-camera/pull/501 <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected ios 13.0, 13.1 ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> When taking an image on ios 13 via camera, the path is returned correctly but the temp image is corrupted. Here is the issue: https://github.com/apache/cordova-plugin-camera/issues/492 ### Description <!-- Describe your changes in detail --> Upon debugging, i found that the image data in `self.data` in `CDVCamera.m` is being released/corrupted after setting the metadata via [`imagePickerControllerReturnImageResult`](https://github.com/apache/cordova-plugin-camera/blob/master/src/ios/CDVCamera.m#L678) The solution is to create a copy of the `NSData` and use that to write the image on disk. ### Testing <!-- Please describe in detail how you tested your changes. --> Open camera on ios 13. Take an image. The image returned should be displayed correctly ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
