breautek commented on a change in pull request #792: Gradle upgrade from 4.10.3
to 5.x
URL: https://github.com/apache/cordova-android/pull/792#discussion_r325230869
##########
File path: package.json
##########
@@ -24,7 +24,8 @@
"cover": "nyc jasmine --config=spec/coverage.json",
"e2e-tests": "jasmine --config=spec/e2e/jasmine.json",
"java-unit-tests": "node test/run_java_unit_tests.js",
- "eslint": "eslint bin spec test"
+ "eslint": "eslint bin spec test",
+ "clean": "gulp clean"
Review comment:
Ahh gotcha. I can move the `gulpfile` to `bin/`. Although gulp is a task
system, so you would run the file with `gulp`, and not node directly and I
would favour keeping the filename `gulpfile.js` because of this. Reason for
adding this tool is to have easier script to clean the test gradle stuff,
without relying on `git` commands. It's a dependency that some other cordova
repos already use so it should be somewhat familiar.
Reason this is being added as part of this PR is because it does require
gradle to be removed for the test directory to use the new version of gradle.
This would only apply to other developers who already have this repository
cloned and they have ran `npm test` before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
