erisu commented on a change in pull request #792: Gradle upgrade from 4.10.3 to
5.x
URL: https://github.com/apache/cordova-android/pull/792#discussion_r325435364
##########
File path: package.json
##########
@@ -24,7 +24,8 @@
"cover": "nyc jasmine --config=spec/coverage.json",
"e2e-tests": "jasmine --config=spec/e2e/jasmine.json",
"java-unit-tests": "node test/run_java_unit_tests.js",
- "eslint": "eslint bin spec test"
+ "eslint": "eslint bin spec test",
+ "clean": "gulp clean"
Review comment:
I am also not in favor of adding the `gulp` dependency to perform a simple
task that could have been achieved with just node.
I will let someone else though review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]