LoicEvenium opened a new pull request #510: (android) fix: use provider prefix 
to avoid conflict with cordova-open plugin
URL: https://github.com/apache/cordova-plugin-camera/pull/510
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   cordova-android
   
   ### Motivation and Context
   Application crash when open the camera if `cordova-plugin-open` installed.
   Providers of `cordova-plugin-open` and `cordova-plugin-camera` are in 
conflicts using the same `android:authorities` value. See the AndroidManifest:
   ```xml
       <provider android:authorities="${applicationId}.provider" 
android:exported="false" android:grantUriPermissions="true" 
android:name="org.apache.cordova.camera.FileProvider">
         <meta-data android:name="android.support.FILE_PROVIDER_PATHS" 
android:resource="@xml/camera_provider_paths"/>
       </provider>
       <provider android:authorities="${applicationId}.provider" 
android:exported="false" android:grantUriPermissions="true" 
android:name="androidx.core.content.FileProvider">
         <meta-data android:name="android.support.FILE_PROVIDER_PATHS" 
android:resource="@xml/provider_paths"/>
       </provider>
   ```
   Fix: #416
   
   ### Description
   Add "camera" in the `android:authorities` to void namespace conflict
   
   ### Testing
   Open camera, take a picture
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to