breautek commented on issue #695: (iOS) Added Semver to version comparison checks. URL: https://github.com/apache/cordova-ios/pull/695#issuecomment-544942362 Looks like there is a couple of tests failing. This is a unit test that you can find here: https://github.com/apache/cordova-ios/blob/be68c9f6d49aff85a5f7a52ffcbfd31d5b018a90/tests/spec/unit/lib/check_reqs.spec.js#L59-L74 ``` 1) check_reqs checkTool method should throw error because version is not following semver-notated. Message: Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) Stack: Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) at <Jasmine> at ontimeout (timers.js:386:11) at tryOnTimeout (timers.js:250:5) at Timer.listOnTimeout (timers.js:214:5) ``` This particular error is stating that a function isn't resolving in a meaningful time, perhaps a `resolve` isn't being called somewhere. This particular test is to test for completely invalid semver, and it's using `v1.0.0` to do that test, which I think under your changes, `v1.0.0` can easily be coerced into a valid semver so you'll likely have to update this to use something a bit more outlandish, such as `a.b.c`. ``` /Users/travis/build/apache/cordova-ios/bin/templates/scripts/cordova/lib/versions.js 183:67 error Trailing spaces not allowed no-trailing-spaces 187:52 error Trailing spaces not allowed no-trailing-spaces 192:1 error Trailing spaces not allowed no-trailing-spaces ``` These are eslint errors, at the following line/column nunmbers there are extra whitespaces that need to be removed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
